pkg
pkg copied to clipboard
knative
[webhook] logger in context should be annotated with webhook type
Issue
When debugging some defaulting webhooks instrumenting SetDefaults on some types had the side-effect of logging invocations from the conversion webhook.
It was not obvious which webhook was doing the invocation of SetDefaults when looking at the logs.
@dprotaso : Can you provide details on which type has logging in SetDefaults function?
Can you provide details on which type has logging in SetDefaults function?
I was adding the logging myself while debugging something. That's where I noticed there are multiple calls originating from different webhooks endpoints and I couldn't disambiguate between them
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.