Dave Protasowski comments

Results 1317 comments of


                                            Dave Protasowski

Webhook should update K8s service info for various callback configurations

/remove-lifecycle stale

Webhook should update K8s service info for various callback configurations

/lifecycle frozen

E2E tests should build the builder-base image and use it for testing

/assign @dprotaso

Consider exposing credentials via an environment variable that isn't $HOME

This explains the need for this workaround https://github.com/knative/build/blob/95e3199746a50f0a4e4ba62f1d8760e9a203b30e/cmd/git-init/main.go#L59-L67

Consider exposing credentials via an environment variable that isn't $HOME

Moving some of the discussion form #373 to here: Some context from @ImJasonH: https://github.com/knative/build/pull/373#issuecomment-424092807 > Another benefit of having a persistent $HOME dir is to support tools that write config...

Consider exposing credentials via an environment variable that isn't $HOME

/cc @nebhale who's been working on the java-buildpack to provide his experience with the BuildCRD

[webhook] support distribution authors who want to add their custom defaulting and validation

cc @whaught @trshafer

[webhook] support distribution authors who want to add their custom defaulting and validation

## Background To elaborate on the issue our defaulting and validating webhooks are tightly integrated with the `resourcesemantics.GenericCRD` interface https://github.com/knative/pkg/blob/1893541a0fac5885032c8ec170fd81234de13f4a/webhook/resourcesemantics/interface.go#L26-L30 https://github.com/knative/pkg/blob/1893541a0fac5885032c8ec170fd81234de13f4a/apis/interfaces.go#L27-L35 This works fine for our types which are versioned...

[webhook] support distribution authors who want to add their custom defaulting and validation

cc @mattmoor for some thoughts

[webhook] support distribution authors who want to add their custom defaulting and validation

/lifecycle frozen