Dave Protasowski
Dave Protasowski
Let's revisit this after the next release. Some thoughts that have come to mind 1. Controlling when the revision is marked failed - this issue wants an extreme case where...
If min-scale is involved then I think the issue might be in a different place - more specifically the PodAutoscaler. For example `PodAutoscalerConditionScaleTargetInitialized` should only be 'True' when we've reached...
Another thing we should do is update the e2e test to surface the issue you found - eg. fail if Ready=True but ReplicaReadyCount < MinScale https://github.com/knative/serving/blob/main/test/e2e/minscale_readiness_test.go
> Revision is set to true even if there is only one pod, even if the minscale is larger than one. No - because I would expect `PodAutoscalerConditionScaleTargetInitialized` to be...
/test istio-latest-no-mesh_serving_main
curling github for a file is getting a HTTP 429 rate limit /test istio-latest-no-mesh_serving_main
One other observation I have - I think as part of the test you should introduce a readiness delay on the second revision. What I'm seeing happen locally is the...
I dug into this more - I think we should fix `PropagateAutoscalerStatus` https://github.com/knative/serving/blob/794c02fca63d7a6addde5eafb46a56d0876514c0/pkg/apis/serving/v1/revision_lifecycle.go#L172 When we have no pods ready we end up with a PA Status of ``` status: actualScale:...
I have the alternate fix in this PR - https://github.com/knative/serving/pull/16094
> The opentelemetry opencensus receiver is scheduled to be removed in August so this might need to be reprioritised https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/opencensusreceiver Thanks for the info we should tackle this for the...