Dave Protasowski
Dave Protasowski
/lgtm /approve /hold wait for other changes
@aliok we have some steps here: https://github.com/knative/community/blob/main/mechanics/SUNSETTING-FEATURES.md In general though I think it depends on the scope and GA level of the component.
Ok tested this locally and confirmed the metrics go away when the revisions are deleted /assign @Cali0707 @linkvt
/cherry-pick release-1.19 /cherry-pick release-1.20
/lgtm /approve /hold wait for other changes
The e2e failures seem legit
Generally after a quick look I like the abstractions used. Though I'm guessing there's something more nuanced that's causing this change to break the e2e tests
/ok-to-test