Damien George
Damien George
Do the calls to `mbedtls_x509_crt_parse()` also need a similar fix? It looks like that function can parse both DER and PEM as well (the latter only when PEM is enabled),...
> Should I include the fix for `mbedtls_x509_crt_parse()` in this PR or should I open a separate one since there is currently no test I can think of to see...
Should be fixed by fbb02d3aeeaa9da082f3ccd411d8e164a526046e
Should be fixed by f96417dbf28617c533e4f2e65c65d1ed11f089fa (although looking up mDNS on the Pico W in AP mode might not work yet).
See related #15523.
IDF was updated to 5.2.2 in fbb02d3aeeaa9da082f3ccd411d8e164a526046e
I have reviewed the changes here and am happy with this PR now. Except the commit that deprecates `machine.soft_reset()` in favour of `sys.exit()`, that needs reconsideration in the light of...
> Also rewrote the suggested `try/except/finally` structure for main.py as the original version locked the user out of the REPL (reset in finally block). This version allows KeyboardInterrupt to drop...
This looks OK to me, although I now wonder why other files in the `main_esp32xx` directories are found OK when building out-of-tree.
> Probably the linker fragment should be copied into the out-of-tree `main` component rather than hard-coded to be in-tree I tested that and it works.