Damien George
Damien George
Thanks, this is a good improvement to help developers.
@projectgus should we put this in 1.25.0, or wait to 1.26.0? I'm happy either way, seems like a low risk change.
I tested this thoroughly on unix, PYBD_SF6, RPI_PICO2_W, running all possible combinations of WLAN tests against those three. Everything passes. Let's merge this!
Thanks for the contribution, this looks pretty good! Did you implement this from scratch, or copy parts from CPython's implementation? I'm just wondering about licensing and copyright. Can you please...
> I just saw CPython Enum. It looks like incredible magic. :-) That doesn't really answer the question. Did you copy this implementation from CPython? Also, please make sure the...
Thanks for writing these docs, definitely needed! But, `ipconfig()` is not yet implemented on esp32 or esp8266 ports. So the docs there shouldn't change. And it means `mpremote` still needs...
These are the network interfaces that need `ipconfig()` added to them: - `extmod/network_ninaw10.c` - `ports/cc3200/mods/modwlan.c` - `ports/esp32/network_lan.c` - `ports/esp32/network_ppp.c` - `ports/esp32/network_wlan.c` - `ports/esp8266/network_wlan.c` - `ports/mimxrt/network_lan.c` - `ports/stm32/network_lan.c` Some of those...
To start with I suggest just implementing the IPv4 config options for `ipconfig()`, on those additional NICs. That should be relatively straightforward, and would be enough to allow this docs...
Thanks for updating, now merged. With this done we can now officially move forward with using `ipconfig()` over `ifconfig()`, and also say we support IPv6 (at least on ports that...
> So, is it now time to enable ipv6 by default on some ports, e.g. pico-W? Yes! That would be a good idea. Feel free to make a PR for...