Damien George
Damien George
I agree this is an issue that needs clarifying. But maybe we can improve the situation so it "just works". See #11604 for an attempt at that, which makes rehashing...
Thanks for this, it's a great addition! Definitely needed. By chance I was working on the docs side of this today: #14040.
Thanks again for working on this. After thinking more about it here are my general comments. I don't think it makes sense to have both `IRQ_RX` and `IRQ_RXIDLE`, especially because...
> So I suggest to have IRQ_RX as the common method and have support for IRQ_RXIDLE as a derived class method. I understand it's simpler to implement what the hardware...
After discussion with @jimmo and @projectgus we came to the conclusion that it makes sense to expose multiple UART IRQs, and then the user can decide which is best for...
@robert-hh I have added tests for all the IRQs added in this PR. I pushed those tests to your branch. Feel free to modify the tests, eg add more configurations...
> The test scripts are now reworked to some extend. Tests pass for almost all supported boards. Excellent, thanks for working on that! I will test them myself.
See the fix suggested here: https://github.com/micropython/micropython/issues/13094#issuecomment-1837652290 That computes the reciprocal first, then the power.
I really want to find a way to make this use less RAM for functions that don't have doc strings. Because at the moment all functions increase by 1 GC...
> Out of interest wrt to the Micropython-stubs project I'd like to understand what the goal is for this feature > > Is it targeting stdlib/micropython code, frozen (. Mpy)...