Damien George comments

Results 1057 comments of


                                            Damien George

micropython/drivers/sdcard.py: Add CRC7 values for SDCard.cmd() function calls

Thanks @multicoder9 for the detailed explanation above. I agree that it's good to just have something that works. But hopefully #765 can be merged very soon, and that will supersede...

extmod/modframebuf.c: handle read-only storage types.

@projectgus and I discussed this PR. We think that it's a useful -- and maybe even necessary -- feature. The point is, it's not currently possible to blit directly from...

extmod/modframebuf.c: handle read-only storage types.

> I'd put width, height, stride and format before the data so it feels like a "header" Yes, that sounds good.

extmod/modframebuf.c: handle read-only storage types.

See #17358 for an alternative which uses a tuple/list instead of `StaticBuffer`.

extmod/modframebuf.c: handle read-only storage types.

@Gadgetoid are you able to just rebase this branch and force push? It would be good to get a new reading on the code size change, to compare with #17358.

extmod/modframebuf.c: handle read-only storage types.

Thanks for rebasing. The adjusted code size report now looks a lot more consistent. Compared with #17358, the implementation here is about 50% bigger on bare-metal targets.

extmod/modframebuf.c: handle read-only storage types.

Closing in favour of #17358.

ports/qemu: Fix inline-if in `lookup_cause`.

Thanks for the fix!

ports/rp2: Enable mbedtls PEM parser.

I'm not against this change, but: 1. It's a big code size increase. 2. It's not adding anything that you can't already do (you can load multiple der files by...

tools: Self-hosting of `mpy-tool`.

@vshymanskyy any comments on the above review?