Damien George

Results 1057 comments of Damien George

> I guess you've tested building modules using newlib outside the CI? I'm using the `riscv32-embecosm-ubuntu2204-gcc13.2.0` toolchain (used for the Pico 2) and I guess that uses newlib? `btree` builds...

OK, sounds like there are a few things to improve here. But let's just take it a step at a time :smile: That makes it much easier to review and...

Thanks, this looks OK to me. @iabdalkader do you have any comment/objection to this change?

> I think the `P` should have never been removed from CPU pin names, because it's listed this way in the datasheet, @jimmo any thoughts ? From the very beginning...

If this change is going to be merged (I think it should be), then the other two Arduino stm32 boards will also need to have their `pins.csv` updated in the...

> I'm just not sure anymore why this change is needed. With the current `pins.csv`, both `Pin("PA0")` and `Pin("A0")` work fine and I get the right pin in each case,...

> it won't save much flash Named pins actually take quite a lot of flash. In this case removing them would save 2700 bytes. That doesn't really matter for the...

> It might be worth looking into a proper fix at the port level, in C, to remove them but still keep support `Pxy` somehow. Yes, agreed. See related #13664.

I cannot reproduce the problem using the supplied code, and the referenced commit version. It works fine, does a DNS lookup and connects to the remote host. But I do...