Damien George

Results 1057 comments of Damien George

> `aiodns` has been published That looks good! We do need a proper solution for DNS lookup in `asyncio`, it should not be blocking.

It looks like this file was just not added to the original commit back in 6190cec14a6514c4adc8dfdc33b355be10db0400 (it's easy to forget to `git add ` ...).

It looks like the subscribe method needs to handle variable length encoding of the payload size, in the same way that connect and publish do.

> Is there a better way to go about handling this situation where the broker 'disappears' and then 're-appears' at some later time? Yes, the current implementation of umqtt.robust does...

See #186 for a fix which will resubscribe to all existing topics if a reconnect is made.

@craftyguy I'd be interested to see your solution. And also if you want to test my solution and give feedback that would be great.

@craftyguy for your example to work I think you need to connect with clean_session=True, because you'll be explicitly resubscribing upon reconnection.

> I also see the PR was merged @craftyguy No it wasn't, so you'll need to pull the PR explicitly to test it.

You should be able to release all keys by calling `keyboard.send_keys(())`, ie pass an empty tuple (or empty list `[]` but an empty tuple is more efficient because it doesn't...

> I plan to make whole umqtt async compatible. See https://github.com/tve/mqboard/tree/master/mqtt_async