Damien George

Results 1057 comments of Damien George

> I'm wondering on what's the policy for new test files after the introduction of `unittest`. Using unittest is only for convenience, if it makes writing the test easier. So...

> * Compressed opcodes start with the `c.` prefix, which I replaced with `c_` - so for example `c.srai` turns into `c_srai` It would be possible to allow `c.` as...

When an rv32 inline-asm function is entered into, what registers are automatically saved? Is there anything else done in the prelude? With Thumb inline-asm, a few registers are saved/restored on...

> the offset-to-register syntax support wasn't bolted on this way What do you mean, that you'd prefer it was designed it from the start?

OK, sounds fine to me. I'm glad that the syntax `10(a0)` is now supported, I think that's a good improvement.

> The prelude saves the function table pointer and the three local registers. Just to be clear, this is necessary for @native/@viper code generation. But for inline-rv32-asm it's not strictly...

@agatti thanks for your efforts on this, it's a very nice feature to have, especially because RISC-V will become more and more prevalent in MCUs in the future. BTW, if...

> I can probably shorten some error messages' text and coalesce some messages as well to further reduce the space taken up by this feature, Note that there are configurable...

Thanks for this, it's a great addition! I haven't had time to look at it properly, but it will definitely need some CI tests: > I made all test verifications...

@agatti this PR is looking really good now, and I've tested it with the natmod examples. Everything passes locally for me, except compiling `features2` (because it needs float) and running...