Damien George
Damien George
> Once the rest of the stmlib updates go through I'll rebase on top of that/master. stm32lib is ready, so let's get that in first via #18268.
I tested this PR on PYBV10. The CDC works! That's a really god milestone. Testing performance with `tests/serial_test.py`, the DATA IN throughput (in to the host PC) is the same...
> I also tried out `machine.USBDevice`. Unfortunately that didn't work Aah, that's simply because it was trying to create a CDC+MSC+HID device and there are not enough hardware endpoints on...
> #define CFG_TUD_CDC_EP_BUFSIZE (4096) I don't think it's possible to change this option, it needs to be the actual size of the endpoint (64 bytes for full speed). I tried...
@andrewleech this is looking really good, thanks. Just some comments to address (see above) which should be mostly uncontroversial. Then it'll be ready to merge.
The CI is failing. I suggest the following patch to hopefully fix that: ```diff --- a/ports/stm32/mpconfigboard_common.h +++ b/ports/stm32/mpconfigboard_common.h @@ -635,8 +635,13 @@ #define MICROPY_HW_BDEV_WRITEBLOCKS(src, bl, n) spi_bdev_writeblocks(MICROPY_HW_BDEV_SPIFLASH, (src), MICROPY_HW_BDEV_SPIFLASH_OFFSET_BLOCKS +...
Thanks for updating, this is looking pretty good now. I'll do some final testing on my side, then hopefully merge.
Merged! Thanks @andrewleech for your efforts with this, it's a great step forward for the stm32 port!
Thanks @jonnor for the detailed debugging. Based on your observations I'm pretty sure your issue (and probably the original issue posted here) is the same as #6592. The point is...
@jonnor any comment/ideas on my comment above https://github.com/micropython/micropython/issues/6769#issuecomment-2227676231 ?