Damien George
Damien George
This will need some tests, ideally to test all new functions, classes and methods introduced by this PR. They can be stand-alone (in `tests/extmod/`) and/or multi-tests (in `tests/multi_net`). You can...
Thanks, this looks OK to me. It would be quite hard to add a test for this, so I'm happy for there not to be a test.
@agatti I would appreciate your comments/review of this, thanks!
@agatti this has been updated based on your feedback, if you'd like to take another look, thanks!
> Just one minor thing: given that picolibc for Arm is also an option on the CI machine, would it make sense to extract the libc selection bit that's currently...
And of course the CI fails now with picolibc...
> I was also wondering, given that there's no RV32 platform in the code size report then maybe adding the size of the qemu repl build there could be nice...
See #15784 for the rename of the qemu-arm port to qemu.
> you may want to increase the heap size for RV32, I just bumped into [#12853 (comment)](https://github.com/micropython/micropython/pull/12853#issuecomment-1798784848) again. The tests are no longer embedded in the firmware, but rather run...
Hmm, that's strange the failure comes up there, with seemingly unrelated changes. All that PR does is enable inline-riscv-asm, and that shouldn't change the amount of GC heap available, or...