Damien George
Damien George
Squashed the fix-up commits and merged in fcfed6a0ea763ff14ea2bf819179fdf7eecda889 through a9801f9960ea2b8e94d5626840c97bc45286e1a3
I think this is fixed now in MicroPython?
Hmm, I see now why it's important to have identity work correctly across the JS-Python boundary. It is possible to fix this on the MicroPython side, so that `PyProxy` objects...
See a fix for this here: https://github.com/micropython/micropython/pull/15349
I haven't done a full review of this yet, but made some comments to start with. Also, the CI needs to be fixed.
> Can this be merged, or is something needed? I need to review and test it. There are merge conflicts that need to be resolved. And for some reason it...
Thanks, this is good, the UART test is now simpler!
> Applying this fix unexpectedly caused ESP32-S3 to come up using the USB Serial/JTAG interface instead of native USB. The config options here were a bit hard to follow, so...
Unfortunately it looks like this PR broke `ARDUINO_NANO_ESP32`: ``` micropython/shared/tinyusb/mp_usbd_cdc.c: In function 'tud_sof_cb': micropython/shared/tinyusb/mp_usbd_cdc.c:134:9: error: implicit declaration of function 'tud_sof_cb_enable'; did you mean 'dcd_sof_enable'? [-Werror=implicit-function-declaration] 134 | tud_sof_cb_enable(false); | ^~~~~~~~~~~~~~~~~...