Damien George
Damien George
Please try to make this work for RP2350. You could detect that chip using: ```py is_rp2350 = "RP2350" in sys.implementation._machine ``` Also, please update the documentation to add the new...
Please can you add a little documentation for these new arguments, to `docs/library/rp2.rst`.
IMO this is a worthy feature to have (although at what level to enable it is a separate question). But it will need: - tests, full test coverage - docs...
> I'm not sure how to add the firmware to the hosted files, we probably need to add the entire build dir. I think we should add just the files...
I've now pushed 2 commits to this PR: - create `firmware.zip` as part of the alif build process, containing relevant files needed to deploy over SEUART - add alif to...
> I've updated the PR so that settrace is only enabled in the coverage build, not the standard build or other variants. Yes, that's a good idea. As mentioned, it...
> * moving the `misc/sys_settrace*.*` tests to their own folder: `tests/sys_settrace` That sounds reasonable, although not in scope for this PR. > * Also if you have guidance how to...
@jepler there's a failing test here on the CI which I think is due to the code taking longer to run now that settrace is enabled. It looks like the...
> Or I could pipe through a timeout multiplier used only for 1 build. Might be worth adding a command line argument for this timeout? And then increase it just...
Let me know when this is ready.