Damien George

Results 1057 comments of Damien George

> these constants should live as part of the `WLAN` class, and thus the `network` module constants are actually just there for backward compatibility That is correct. > If that's...

> * _not_ add the constants to `network` > > * add them to the `WLAN` class instead > > * add a comment to in `network`'s source code explaining...

I removed the `ediv_rand_present` asserts in #16120.

I've rebased this on latest master, cleaned up a few things, and force pushed. Tested on ESP32_GENERIC. Everything seems to work except `thread/mutate_bytearray.py` when run as native code, it locks...

I rebased this on master to get the above-mentioned patches. This PR is now quite a bit simpler.

Thanks @DvdGiessen , I have applied your patch. I also rebased this on latest master. @projectgus I think we can merge this, what do you think? We won't official move...

Merged. Thanks everyone who worked on this.

> Setting [CONFIG_ESP_SYSTEM_HW_STACK_GUARD=n](https://docs.espressif.com/projects/esp-idf/en/v5.2.2/esp32c6/api-reference/kconfig.html#config-esp-system-hw-stack-guard) resolves the crashes. Is this the correct fix though? I doubt that's a good fix, it's more of a workaround. Instead it would be good to understand...

According to https://github.com/micropython/micropython/pull/11869#issuecomment-2405116837 this also needs fixing for ESP32-C6.

> this also needs fixing for ESP32-C6. I'm able to reproduce the original bug reported here using `ESP32_GENERIC_C6` firmware, on current master 82e69df33e379bf491bea647e217d6d56c5b8090, with the code https://github.com/mzakharocsc/micropython/blob/c6/ports/esp32/modules/main.py . Actually to...