dpad85
dpad85
Thank you for this work, there are a lot of great points. Our initial version had the Bolt12 QR code in the carousel alongside the others, but we changed that...
That's a good idea. There are several options, like using a mix of the user's payer key + a static element of the payee's offer to build this deterministic payer...
Good idea, that's something we could add in the experimental feature section for now. > it should verify that the address does actually resolve to the users bolt12 offer before...
In Phoenix, are you able to reach the step where you have scanned the LNURL-withdraw code, reached the screen with the withdrawals details (including the amount), and triggered the withdrawal?...
What device are you using ? Are you using a stock Android or a custom ROM ? > at launch Is the app able to run for at least a...
We should use the code made for phoenixd (the server version of Phoenix), see https://github.com/ACINQ/phoenixd/pull/115 The Phoenixd version does contain the payment hash, though not on-chain details since phoenixd does...
The payment hash is included in the CSV export since v2.5.0, but the destination field was buggy. It's been fixed, and next version will contain the address for on-chain outgoing...
Tested on Phoenix Android (see https://github.com/ACINQ/phoenix/pull/755) and it looks good to me. Though we should wait for iOS support before merging.
Notes: - the SKIE release v0.9.0 is now compatible with kotlin 2.0.20. - we should move to the "direct integration" model : https://kotlinlang.org/docs/multiplatform-direct-integration.html. A test commit is available here: 41c1d151fc37fae662d2e91db614b691228d91a7...
Superseded by https://github.com/ACINQ/phoenix/pull/654.