dpad85

Results 162 comments of dpad85

**Comment by [patestevao](https://github.com/patestevao)** _Wednesday Apr 04, 2018 at 13:56 GMT_ ---- Hi, thanks for answering. Nice to know that the color will be different in the mainnet version. Even so,...

> What do you think @dpad85, is that an acceptable way of handling backwards-compat for previously failed payments? For backward compat, it would work, yes. However, these changes do not...

Testing this PR on Phoenix, and trying to pay an already paid invoice a second time, I hoped to get a `Part.Status...RecipientRejectedPayment` failure. Instead, the parent payment status is `FinalFailure.RetryExhausted`....

Looks good. However this will require work on Phoenix side to account for the `Source` type change in the database.

Note: this PR is paused as there are side-effects with electrum (see https://github.com/ACINQ/lightning-kmp/pull/483#discussion_r1236735367). Removing the explicit `bootChannels` flow prevents us from distinguishing: - channels not loaded yet - channels loaded...

The warning message about FCM could let the user choose to run the app as a permanent foreground service. It should not be too hard to do since we are...

Sorry for the delay, we have fixed the issue. There was a misconfiguration in the iCloud settings. No need to update the app, you should be good now. If not...

I'm not able to reproduce the issue with WoS. I can pay a Phoenix generated invoice from WoS without errors, even with an expiry of 1 week or 3 weeks....

The fix will be available in the next Android version. For iOS, we'll need a separate commit so I reopen the ticket.

> You can probably also drop the requirement for onion addresses Yes that's what we do already. We'll think about whitelisting local addresses, with a warning I think it should...