dpad85

Results 162 comments of dpad85

The core issue is that in eclair-core we don't use the same logic for computing the placeholder transaction using all available funds, and for sending the actual channel funding transaction....

Sure, the funding transaction is created here: https://github.com/ACINQ/eclair/blob/android/eclair-core/src/main/scala/fr/acinq/eclair/blockchain/electrum/ElectrumEclairWallet.scala#L39 Which uses the `completeTransaction` method (the actual part that bothers me is [here](https://github.com/ACINQ/eclair/blob/android/eclair-core/src/main/scala/fr/acinq/eclair/blockchain/electrum/ElectrumWallet.scala#L974)) The `InsufficientFunds` error is raised [here](https://github.com/ACINQ/eclair/blob/android/eclair-core/src/main/scala/fr/acinq/eclair/blockchain/electrum/ElectrumWallet.scala#L940).

Thanks for reporting the issue. It looks like the diff is mostly classes that are generated by the SQLDelight library, which is used for the new database storing payments metadata....

The `1.4.2` tag has been pushed. The issue with SQLdelight has not been fixed yet so you will have the same issues as with previous releases. I reckon it will...

FYI in Android, localization is system wide - and it's not only the strings, but also the dates, number formatting, etc... Apps are supposed to follow the system. It's possible...

The issue is still there. However with the wording change for that notification in v1.3.2 (https://github.com/ACINQ/phoenix/blob/master/app/src/main/res/values/strings.xml#L316) it's not that bad, we can keep displaying the message even if the user...

This issue is temporary and specific to the state of the current Android implementation vs iOS. As mentioned in the readme, we do not use the same Lightning engine on...

Yes they are incompatible. However the new Android version will still contain the old engine (as well as the new) in order to be able to restore and use old...

Good catch, thanks!

Hello, > Myt mnemonic seed restores 0 btc in electrum when I select Standard Wallet > I already have a seed > (I put in my 12 words) > I...