human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

#4982 - Add "on the fly" addition of donation sites when entering a donation

Open neenu-chacko opened this issue 8 months ago • 7 comments

Resolves #4982

Description

  • Added functionality for on the fly addition of donation site from new donations page
  • Added specs to test the same
  • Fixed the modal header alignments

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

  • Run rspec spec/system/donation_system_spec.rb

Screenshots

https://github.com/user-attachments/assets/3d7379a1-c756-4f18-ab2b-e31914bca179

neenu-chacko avatar Apr 18 '25 15:04 neenu-chacko

It'll probably be Monday before I get to reviewing this.

cielf avatar Apr 20 '25 01:04 cielf

LGTM functionally. Over to @dorner for technical comments.

cielf avatar Apr 21 '25 16:04 cielf

Hey @dorner -- it looks to me as if @neenu-chacko made the requested changes, but maybe didn't request a re-review. Can you take a look?

cielf avatar May 28 '25 01:05 cielf

@cielf the primary concern hasn't been addressed (the PR is still using JS ERB).

dorner avatar May 30 '25 19:05 dorner

@neenu-chacko Are you still working on this? If we don't hear back in a couple of days, we'll assume that we need someone else to finish this off.

cielf avatar Jun 04 '25 00:06 cielf

@cielf Sorry, I missed the messages. I won’t be able to follow up on this anytime soon, so it’s totally fine to pass it on to someone else if needed.

neenu-chacko avatar Jun 04 '25 04:06 neenu-chacko

@neenu-chacko Ok .. we'll mark it as open and point to your PR. Please do check back when you can -- sometimes this sort of 'last mile' work isn't picked up quickly.

cielf avatar Jun 05 '25 13:06 cielf