rubyforgood
Superadmin Partners View (4682) & Category Dropdown Error (4674)
Resolves #4682 and #4674
Description
The super admin partners view is now in alphabetical order. If you have an error on new item, the category list for selection will not disappear anymore.
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I reopened the super admin page after implementing my changes and the partners are now in alphabetical order. I tried to reproduce the bug after implement my bug fix and I was unable to do so (categories will show up now despite an error). Everything else still works as expected.
Screenshots
Hey @bdeanhardt -- Thank you! -- we'll take a look. One thing for future -- we usually put a PR for each issue we work on -- it's easier for the testers.
Also for future -- it's a better practice to make a branch, rather than making the changes in your main.
@bdeanhardt Could you make the order "human alphabetical" -- i.e. case insensitive, aka lower case alphabetical?, rather than "computer alphabetical", which orders all the lowercase after all the upper case, please?
(We're in the process of making the order of all the other alphabetical lists case-insensitive)
Thanks,
@bdeanhardt Functionally, this looks great! -- just waiting for those automated tests, then I'll pass it over to our tech lead for a final technical review.
Can you add or modify an existing test to validate these fixes?
tests are in! Thank you for your patience on this.
One comment on the newly added test. Shouldn't there be one more added test since there are two issues being fixed here?
I forgot to push the other test! I'm so sorry totally my bad.
👋 This PR is stale and can no longer get commits from anyone else to take it to the finish line. Would suggest closing in favour of the PR I opened and linked above (all changes have been copied over).
