Ryan May

Results 784 comments of Ryan May

I'm happy to consider those kinds of performance improvements, but any such addition needs to consider the maintainability and sustainability of the project. We have a minimal set of maintainers...

It's unclear from your example if there's something else going on. You run `p = cartopy.crs.PlateCarree()`, but your `timeit` is checking `proj`.

While the microbenchmark definitely agrees with the hotspots identified by @andhuang-CLGX's profiling, I think more detail at what holoviews is doing is necessary to see how `equals` and `__init__` to...

It looks like it's trying to install Cartopy 0.18, which only works with PROJ

Code changes look good in general. Looks like this broke the `test_grid_labels` test in `test_gridliner.py`, and angered Travis by trying to generate some HTML with the result image base64-encoded.

The change seems sensible. It's unclear to me whether the test failure is related.

Currently the PR is showing an empty etopo1.jpg committed? Any reason that needs to be included?

Can you rebase your commits to "squash" together the original commit adding the file and the one deleting it? Otherwise, there will be a copy of the 1.3MB file sitting...

General experience that crashes like that are caused by CartoPy's compiled code and what it's linking to, which is PROJ and GEOS/shapely. Most of the time a conflict between the...

Test failure looks real, but I can't readily tell if it's because of your change or upstream.