cartopy
cartopy copied to clipboard
SciTools
MNT: Change map_projection to projection for Axes creation
The GeoAxes class now requires the projection keyword argument rather than map_projection to be more consistent with how a normal Axes is created. In particular, this makes working with AxesGrid and other toolkits easier by enabling a consistent keyword when passing subplot_kw, axes_class, etc...
closes #1979
The change seems sensible. It's unclear to me whether the test failure is related.
Hm... I am pretty sure it isn't related to this because this would have complained about bad "map_projection" or similar errors.
Perhaps the numpy 1.22 floating point difference from AVX512... The difference is just over the tolerance now and only on the Linux runners.
@dopplershift, I think the failing tests were due to the floating point issues with AVX512 after all. I added a commit to increase the floating point dtype size https://github.com/SciTools/cartopy/pull/1980/commits/7c71977b659c402cd1846dd9ab2ef9de7c146b68, which appears to have fixed the failing CI. I can break that out to another PR if it would help too.
@dopplershift, I think the commit to address that other failed test example is in this PR... Maybe I should have broken it out :)