cartopy icon indicating copy to clipboard operation
cartopy copied to clipboard

Fix limits/threshold of projections with non-default Globe

Open QuLogic opened this issue 5 years ago • 4 comments

Rationale

Some limits and thresholds are hard-coded, but this causes incorrect projections when the Globe radius is much smaller than the default. Either the map is tiny in very large limits, or lines are not projected correctly.

Implications

TransverseMercator is no longer tiny when using a small Globe radius; other projections do not cut projected lines randomly.

QuLogic avatar Jul 12 '20 08:07 QuLogic

Code changes look good in general. Looks like this broke the test_grid_labels test in test_gridliner.py, and angered Travis by trying to generate some HTML with the result image base64-encoded.

dopplershift avatar Jul 14 '20 05:07 dopplershift

Weird, I thought I saw that failure before making this change and thought it was unrelated, but I guess not.

QuLogic avatar Jul 14 '20 08:07 QuLogic

The test failure is because the AzimuthalEquidistant is now missing a whole bunch of lines. I rebased hoping that your 1000-point PR would have fixed it, but it appears not. image

QuLogic avatar Aug 06 '20 07:08 QuLogic

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 08 '24 16:04 CLAassistant