Dominik Moritz

icon indicating a website link https://www.domoritz.de icon indicating an email [email protected]

icon company CMU, Apple icon location Pittsburgh icon location Faculty at CMU (@cmudig) and researcher at @apple. PhD in Computer Science from the University of Washington (@uwdata, @uwdb). Co-creator @vega, @streamlit.

Results 1544 comments of Dominik Moritz

Changing whether a field is optional (`?`) changes the schema

Have you tried https://github.com/vega/ts-json-schema-generator? It's the generator I actively maintain.

Compiling fails for typescript-json-schema.ts file

Yeah, it would be nice to support strict null checks. I'd be happy to review a pull request.

first class TS advances types stringified instead of expanded

I'd say so. It's the generator I maintain (after moving from this one) and we use it for Vega-Lite which is a pretty complex type.

first class TS advances types stringified instead of expanded

That's a broad statement that I do not support. The test cases are a superset of the tests here: https://github.com/vega/ts-json-schema-generator/tree/next/test/valid-data. Failures are dependent on your use case.

Integration strategy with ajv library for parsing "Date" fields

Thank you so much for writing this up @benny-medflyt!

Added function parameters definition in schema when using `typeOf` keyword

How does this compare with what ts-json-schema-generator does?

Bug | null dropping alias annotations

As you discovered, this is expected behavior given the Typescript semantics.

Bug | null dropping alias annotations

Please describe the minimal program you encounter the issue with.

Optional array / tuple elements

Happy to review PRs for this bug.

Typo. between CLI and Args? - `aliasRef` or `aliasRefs`

Yeah, these should be consistent. Can you send a pull request?