Dominik Moritz

icon indicating a website link https://www.domoritz.de icon indicating an email [email protected]

icon company CMU, Apple icon location Pittsburgh icon location Faculty at CMU (@cmudig) and researcher at @apple. PhD in Computer Science from the University of Washington (@uwdata, @uwdb). Co-creator @vega, @streamlit.

Results 1544 comments of Dominik Moritz

GH-40407: [JS] Fix string coercion in MapRowProxyHandler.ownKeys

Python (which uses C++ which could be considered the canonical implementation) only allows string keys. ```py Traceback (most recent call last): File "/Users/dominik/Code/ramsch/map.py", line 8, in table = pa.table({'a': range(10),...

GH-40407: [JS] Fix string coercion in MapRowProxyHandler.ownKeys

Oh, `pa.table` doesn't recognize the dictionary. Thanks for the corrected code!

The example does not work

Hmm, try building the top level module.

bug in browser plugin

Can you reproduce this with the example in the example folder?

Conversion to use hooks needs more consideration.

Thanks for the issue. Do you have a few cycles to update the behavior? What's the disadvantage of doing a revert?

Conversion to use hooks needs more consideration.

I'm happy to revert the change. Can you send a pull request?

weird state change in newest version

Thanks for looking into this. Since you identified the version that introduced the issue, can you send a pull request to resolve this?

After updating to the latest version 0.54.0, an error occurred

Did you try the editor example? I don't see the issue. Please follow the issue template.

Inserting 0 row JSON or Arrow data causes fatal error

Is this related to https://github.com/duckdb/duckdb/issues/7200?

insertArrowTable swaps column values

> It seems the order of columns (in the array of objects as an input to [arrow.apache.org/docs/js/functions/Arrow_dom.tableFromJSON.html](https://arrow.apache.org/docs/js/functions/Arrow_dom.tableFromJSON.html)) matters; the values are added based on the position in the object, and...