typescript-json-schema icon indicating copy to clipboard operation
typescript-json-schema copied to clipboard

Typo. between CLI and Args? - `aliasRef` or `aliasRefs`

Open AlexYates opened this issue 3 years ago • 1 comments

The CLI has a flag called aliasRefs, but the exported arguments from typescript-json-schema.ts have aliasRef.

Usage: typescript-json-schema <path-to-typescript-files-or-tsconfig> <type>

Options:
...
  --aliasRefs           Create shared ref definitions for the type aliases.          [boolean] [default: false]
...

https://github.com/YousefED/typescript-json-schema/blob/4910db050e4870a53d09a810ae189f70e4b4310f/typescript-json-schema-cli.ts#L13

const settings: TJS.PartialArgs = {
  // aliasRefs: true,
  aliasRef: true,
};

https://github.com/YousefED/typescript-json-schema/blob/2254b1a04929ae786abe3f7ec07b58b407154729/typescript-json-schema.ts#L70

AlexYates avatar Aug 30 '22 21:08 AlexYates

Yeah, these should be consistent. Can you send a pull request?

domoritz avatar Aug 30 '22 22:08 domoritz