Dominik Moritz

Results 1544 comments of Dominik Moritz

I have not seen this come up before. Looks like it.

Did you eject react scripts? Then you can add the webpack plugin as shown in the examples.

Sorry, typo, I meant eject. When you eject, you can modify your webpack config to use MonacoWebpackPlugin. We need to import from esm so that we only get the language...

Sounds like an issue with the build system or https://github.com/microsoft/monaco-editor-webpack-plugin. I don't think there is enough detail here to fix the issue, unfortunately.

I don't have the cycles to debug this but maybe someone else can chime in.

Do we need this callback or could you add it yourself to the editor (which you get with `editorDidMount`)?

This sounds like a Monaco issue, no?

I think the loader should absolutely live in ts. Have a look at how we customize loaders in Vega as an example for what I mean. I think your example...

https://github.com/vega/vega/tree/master/packages/vega-loader has a good API. I think the loader mostly needs a function `(url: string) -> data` where one can customize exactly where to fetch the data from and how...