Dominik Moritz

Results 1544 comments of Dominik Moritz

This is great. I think having top level signals makes sense especially if we can use them to write. I wonder whether we even need the helper functions in that...

I don't know how forward compatible we need to be and I don't see us changing how selections are implemented anytime soon. Thus, I lean towards not providing helper functions....

Let's see how we name the signals. I'm expecting the signal names to directly correspond to the selection names.

@simon-lang We are working on improving this, which we will release in Vega-Lite 3. See https://github.com/vega/vega-lite/pull/4068 for details.

@arvind we can close this issue once we have documented the new API, right?

Currently, you can read but not write selections.

@bearzx See my comment from two weeks ago. We hope to have a write API for Vega-Lite 4 but no promises.

Yep, for now you go through the view API. @arvind implemented that the names are consistent with the names of the selections.

This looks like a bug we should fix. Thanks for the pull request.