Dominik Moritz

icon indicating a website link https://www.domoritz.de icon indicating an email [email protected]

icon company CMU, Apple icon location Pittsburgh icon location Faculty at CMU (@cmudig) and researcher at @apple. PhD in Computer Science from the University of Washington (@uwdata, @uwdb). Co-creator @vega, @streamlit.

Results 1544 comments of Dominik Moritz

Memory leaks on diff editor

Why not? Who keeps a reference?

Memory leaks on diff editor

Thanks for tracking this down! Could you send a PR to fix the issue? It doesn't have to be immediately.

Breaking Jest tests

I think you need to run babel over your files. Looks like jest does not like the import syntax.

editor throw "Model is disposed" error when i typing

Thanks for the report. Can you provide a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) that demonstrates the issue?

Storing a model for different "files"

We only get the model from the editor (see https://github.com/react-monaco-editor/react-monaco-editor/blob/master/src/editor.tsx#L57). So you can probably just swap out the model in the editor without changing the library at all. Can you...

Storing a model for different "files"

Do you have a suggestion to resolve this issue?

Options should accept IStandaloneEditorConstructionOptions

Can you send a pull request to fix this issue?

loader.js does not load the files because of browser refuses AJAX request

Does the example in their repo work?

Implement DiffNavigator

Like https://github.com/superRaytin/react-monaco-editor/blob/master/src/diff.js?

Implement DiffNavigator

Ahh, I see. I don't plan to add it as I don't use the diff editor but someone else might.