Dominik Moritz

Results 1544 comments of Dominik Moritz

This would mean that any browser has to have support for string templates unless we compile down to concatenation.

We always parse expressions and generate code. But the code mostly stays the same.

Instead of adding this to the readme, could we change the package to work in the browser (and test it)?

Vitest can easily run in the browser for example. I just moved Vega-Lite to it in a pull request.

Maybe jest has some something similar? Maybe vitest has caught up in v3? Or we just accept the slower test times (and report it to hope they fix it).

I think we are running into https://github.com/vitejs/vite/issues/8619. I got it mostly working but you need to save your Vite config file right now. The plus is that you don't even...

I feel the default should be to use the ends where possible, no? Does this need to be configurable?

Yeah, I don't think we support this use case and likely won't as (imho) the data source should be fixed. For now, you can fetch the data yourself, parse it,...

Yep. Can you try with another browser?

Vega-Embed has an "open in the editor" action that uses an API in the editor to load the spec. Maybe that works as well (although you can only trigger it...