Dominik Moritz

Results 1544 comments of Dominik Moritz

Closing unless we change our stance on supporting UMD going forward.

It works with the adapter but I thought the idea of the Vite plugin is that I don't need an adapter anymore. ``` import adapter from "@sveltejs/adapter-cloudflare"; import { vitePreprocess...

Ah ok, thanks for clarifying. I'll use the adapter for now then.

Makes sense but doesn't feel high priority right now to be honest. I think making copying too easy could be even problematic for partial snippets where the user needs to...

Very cool that you figured out how to create precomputed results using jsdom. I think that faster load times are a really big improvement for Mosaic and would love to...

Very nice! > I also noticed the typings for Connection.query aren't right for the create or load bundle commands. Can you point me to that? > A small concern is...

Good point. Does https://github.com/uwdata/mosaic/pull/549 look right to you?

> But it does seem harder to load the bundle because it needs to read those files into memory and update the cache, which is in the browser for WASM...

Filed https://github.com/uwdata/mosaic/issues/550

Since https://github.com/uwdata/mosaic/pull/358, Mosaic has a JSON schema (e.g. https://github.com/uwdata/mosaic/blob/main/docs/public/schema/v0.10.0.json) for the spec format so we should be able to use https://github.com/vega/altair/tree/main/tools/schemapi to generate the Python API. The idea is to...