Dominik Moritz

icon indicating a website link https://www.domoritz.de icon indicating an email [email protected]

icon company CMU, Apple icon location Pittsburgh icon location Faculty at CMU (@cmudig) and researcher at @apple. PhD in Computer Science from the University of Washington (@uwdata, @uwdb). Co-creator @vega, @streamlit.

Results 1544 comments of Dominik Moritz

feat: inline clip-path instead of id ref

I'm curious why this issue happens. Vega does increase the clip id whenever you use a clip id. Could it be that you have multiple instances of Vega?

feat: inline clip-path instead of id ref

Oh I see. So you render the chart and then just embed the SVG.

Support ppi argument

I think it makes sense. We already have `scaleFactor` and I'm not sure whether we can use ppi in `view.toImageURL` in https://github.com/vega/vega-embed/blob/617a57b97810ea59ebac519cac51ce2fd63100b7/src/embed.ts#L475. Do you know what we need to change...

Support for multiple types in asType

Makes sense. Can you send a pull request?

RegExp types are now emitted, breaking schema validation (v2.1.1)

What if you just have a regex?

Incorrect schema generation for `NonNullable` of union type

NonNullable internally uses `T & {}` which I guess we don't handle well. Pull request welcome.

Incorrect schema generation for `NonNullable` of union type

Step through (instructions in the repo) the parsers with a debugger to see what it constructs and at which points it's wrong. If the parsing looks fine, step through at...

`tsconfig.json` not being loaded by default

Hmm, just noticed that this example is providing both a file path and a project. Usually you don't need the file path with a project if the type is unique.

`no-useless-spread` False positive with iterator helpers

Also false positives with typed arrays that one may want to be converted to an array of numbers. ```ts [...int32Array.slice(1)] ```

feat: align label to start of chart

Thanks for taking a stab at this. Would frame (similar to titles) be the more fitting term?