Daniel O

I would benefit greatly from this as a v2.0.0 and breaking change.

https://github.com/apokalipto/devise_saml_authenticatable/pull/245 fixes tests, add coverage.

This would be useful for us. +1 to a PR.

Okay, that's positive. This feels quite... ugly... to mutate global state in a class when a configuration flag is set.

Annoying. ``` NoMethodError: undefined method `single' for {"first_name"=>["John"], "email"=>["[email protected]"], "groups"=>["admin", "reporting"], "multiple_but_single"=>["1", "2", "3"], "lastName"=>["Smith"]}:Hash ``` However, that should be a OneLogin::RubySaml::Attributes object with those methods.

In https://github.com/apokalipto/devise_saml_authenticatable/pull/245 I did a version of SxDx's work with test coverage, but it doesn't feel right as users are mutating global state. I think the better answer to this...

Bear in mind, the vendored version of signature_pad is approximately ~5 years outdated by this point. https://github.com/szimek/signature_pad/releases?page=3

This is a bit of a pain. You can redefine attr_encrypted and manually specify an `iv:` When you do: ``` devise :two_factor_authenticatable, otp_secret_encryption_key: ...... ``` It does ```attr_encrypted :otp_secret, key:...

https://github.com/voxpupuli/puppet-rabbitmq/pull/464 is basically this but for puppet.

We see similar: ``` NoMethodError: undefined method `username' for nil:NilClass devise_saml_authenticatable (1.9.1) lib/devise_saml_authenticatable.rb:152:in `public_send' devise_saml_authenticatable (1.9.1) lib/devise_saml_authenticatable.rb:152:in `block in ' devise_saml_authenticatable (1.9.1) app/controllers/devise/saml_sessions_controller.rb:57:in `store_info_for_sp_initiated_logout' activesupport (6.0.6.1) lib/active_support/callbacks.rb:428:in `block in make_lambda'...