devise_saml_authenticatable icon indicating copy to clipboard operation
devise_saml_authenticatable copied to clipboard

Support for multiple/mixed attribute types.

Open doconnor-clintel opened this issue 1 year ago • 2 comments

Revised version of https://github.com/apokalipto/devise_saml_authenticatable/pull/159

  • Fixes specs
  • Adds coverage for multiple groups, based off of okta samples

doconnor-clintel avatar Dec 06 '23 05:12 doconnor-clintel

Okay, that's positive.

This feels quite... ugly... to mutate global state in a class when a configuration flag is set.

doconnor-clintel avatar Dec 06 '23 08:12 doconnor-clintel

Annoying.

NoMethodError:
        undefined method `single' for {"first_name"=>["John"], "email"=>["[email protected]"], "groups"=>["admin", "reporting"], "multiple_but_single"=>["1", "2", "3"], "lastName"=>["Smith"]}:Hash

However, that should be a OneLogin::RubySaml::Attributes object with those methods.

doconnor-clintel avatar Dec 19 '23 04:12 doconnor-clintel