devise_saml_authenticatable icon indicating copy to clipboard operation
devise_saml_authenticatable copied to clipboard

Published 20 hours ago • verified publisher icon apokalipto

Support single and multi value attributes

Open SxDx opened this issue 5 years ago • 6 comments

I think it is essential to handle both single and multi value attributes as Identity Providers often send responses containing both types, e.g. single for email and multi for roles.

I have provided an example of the new attribute map yaml. The type is configureable per attribute.

The change is not backwards compatible but it would be relatively easy to add if it is a blocking issue.

SxDx avatar Feb 11 '20 14:02 SxDx

I fixed the tests on master, so you should also merge/rebase master again.

adamstegman avatar Feb 14 '20 23:02 adamstegman

Hi Guys, any update about this PR? It will help a lot here =)

victorlcampos avatar Oct 20 '20 17:10 victorlcampos

Bumping to see if there's any plans to include this as well. Having multiple attribute values for roles would be a big plus

khuong-acorns avatar Nov 09 '21 01:11 khuong-acorns

I think this would be quite a valuable addition, but perhaps the way it is done should be changed a bit to be compatible with current setups without having to change the existing yml files for single value attributes. May look into making a PR for that if I find a good way to do it.

Taeir avatar Aug 13 '23 21:08 Taeir

I would benefit greatly from this as a v2.0.0 and breaking change.

doconnor-clintel avatar Dec 06 '23 04:12 doconnor-clintel

https://github.com/apokalipto/devise_saml_authenticatable/pull/245 fixes tests, add coverage.

doconnor-clintel avatar Dec 06 '23 09:12 doconnor-clintel