David Schneider
David Schneider
Fixing this PR should be pretty straightforward...
No, I suspect you're just missing an include.
Thanks! Can you please rebase (or squash) this branch to get rid of the extra commits and reverts? Also, at a minimum this target should depend on x11. The currently...
@tsimonq2 if you fork @zxvv's branch and fix the testing errors, you could submit a PR with your fixups on top of @zxvv's commits.
> I'm not entirely sure what the issues are here, even after reading it over. that's because the issues are confusingly described [here](https://github.com/dnschneid/crouton/pull/2532#issuecomment-227546165). > And it's LXQt, not LXQT. this...
(extra patches) [0001-Fix-LXQT-target-error-message.txt](https://github.com/dnschneid/crouton/files/520410/0001-Fix-LXQT-target-error-message.txt) [0002-Add-Mate-and-LXQT-w-tests.txt](https://github.com/dnschneid/crouton/files/520409/0002-Add-Mate-and-LXQT-w-tests.txt)
Probably after #1144 is merged.
phew.
@mathuin also pointed out that xterm isn't installed automatically on some targets.
@EddieRingle xiwi-app got merged into master. i3xiwi is likely to get merged next, and xiwif is a bit of a testing ground at the moment.