crouton icon indicating copy to clipboard operation
crouton copied to clipboard

src/freon.c: Check before extracting mode in open

Open jbaum98 opened this issue 7 years ago • 4 comments

Fixes #3140

jbaum98 avatar Jun 14 '17 05:06 jbaum98

Fixing this PR should be pretty straightforward...

dnschneid avatar Nov 20 '17 06:11 dnschneid

Sorry I didn't see this. So should I define O_TMPFILE to be a number with only ones so that bitwise or-ing it has no effect? Ie ~0?

jbaum98 avatar Nov 20 '17 22:11 jbaum98

No, I suspect you're just missing an include.

dnschneid avatar Nov 20 '17 22:11 dnschneid

Okay I've added an #include <fcntl.h> based on the man page, but I don't have a linux machine handy right now to test it. The commit is here: 51ffe99319896c901e8f91f0abf8066e4eb93c95 but I can't push it because I've deleted the original branch.

jbaum98 avatar Nov 20 '17 22:11 jbaum98