Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

Great, thanks for confirming. The entire internalization/externalization logic between Go's `time.Time` and JavaScript's `Date` object is quite custom and specific. ``` Go type Test struct { *js.Object Time time.Time `js:"Time"`...

I should also confirm, are you aware that Go's `time.Time` maps to JavaScript's `Date` object? It can be seen here: https://godoc.org/github.com/gopherjs/gopherjs/js Here are some tests that exercise some of that:...

> But for the simpler example here: https://github.com/oskca/gopherjs-vue/blob/master/examples/unwritableTime/main.go#L20 with no VueJS code, It still show the `Uncaught Error`. Yeah, I agree that's a bug and should be fixed. I'll continue...

This sounds related to https://github.com/gopherjs/gopherjs/pull/240. Before that PR, there was no clean mapping from `js.Undefined` to JavaScript's `undefined` either. Perhaps this is yet another similar unhanded case. I need to...

I've honestly almost never dealt with `js.Error`s, so I can't speak from experience here `js.Error` is defined as: ``` Go type Error struct { *Object } ``` I tried your...

Actually, looking at this one piece of code that deals with possible `*js.Error`s, I'm not sure if that's correct: https://github.com/gopherjs/websocket/blob/867cdcb6edcfa907c935102a8b91c3d85317747c/wrapper.go#L106-L114 Since it only checks if `jsErr` is nil and not...

> However, we may want to reconsider what happens when `null` gets internalized to such a pointer to a struct. @shurcooL @dominikh Do you think it makes sense to internalize...

> #759 fixes this bug. That's this issue. Did you mean PR #760? Also, how does this intersect with #742? I haven't gotten around to reviewing it properly, but I...

Here are my results: ``` $ go run go_html_template_bench.go Parsing time elapsed: 772.079971ms Execution time elapsed: 353.283692ms $ gopherjs run go_html_template_bench.go Parsing time elapsed: 8.695s Execution time elapsed: 9.207s ```...

:O Yes, this is very interesting!