Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

Also, do you have any theories or ideas why this stack size comes up only on this PR, but not on master? Or does it also happen on master, just...

Thanks for the detailed analysis. About the proposed change, I'll take more time to think about it, but my initial reaction is that it sounds much better.

Thanks. This addresses all of my initial review feedback, which covered `tool.go` and style comments. Next up the actual meat of the PR, the changes to compiler to fix #661,...

I've seen this failure for the first time recently when working on `go1.9` branch: ``` === RUN TestMaxExecDepth FAIL text/template 2.315s ``` It has happened 2 times out of 10~20...

I can reproduce on gopherjs playground: http://www.gopherjs.org/playground/#/QlMAXNNSG9 Interestingly, it doesn't happen if you add something like `fmt.Println()` at the end: http://www.gopherjs.org/playground/#/1Ec8axHq-N

I'll note that in Go 1.16 an [-overlay flag](https://golang.org/doc/go1.16#overlay-flag) was added, which may be relevant. (CC @matloob.) In general, given the limited resources, I think it's very reasonable for GopherJS...

Thanks for reporting this @flimzy. It's definitely a bug/issue if it's not documented and doesn't work. We should fix it either via documentation and more graceful error message, or by...

From https://github.com/golang/go/issues/6719: > My suggestion is that we change the map code so that when iterating over a bucket it randomly goes either up or down. That will cause a...

I was pretty sure I've seen a tool or a script that does this, but after spending a few minutes searching, I couldn't find it now. Hopefully someone else can...

This is not a bother, thanks for reporting it @oskca! I think this is likely a valid issue. I plan to get around to looking at this soon, I just...