Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

> The guy who wrote it doesn't have a github account anymore it seems: 725b543 He does, it's @linuxerwang. It's just the email he used to author that git commit...

Hi. I'd like to chime in here and offer some observations and point out an opportunity. First, huge, huge thanks to @nsf (and contributors to gocode) for creating gocode and...

> > following the Go idiomatic style would make it easier for other people to do that > > What exactly in my style prevents users from contributing? I didn't...

That's awesome. I think I'll find this useful too. Thanks @nsf!

Removing Soon label since [CL 422037](https://go.dev/cl/422037) added a " && !goexperiment.unified" build constraint, so the builder doesn't fail now. Thanks.

Since this is in Go1.18.6 milestone, added a "[1.18 backport]" suffix and a CherryPickCandidate label so this doesn't get missed during backport review, but I expect it to get approved...

I'll move this issue to Go 1.20 milestone since the fix will need to land on master branch first. To address this issue for minor releases, we'd need to use...

@prattmic The backporting approach described in https://github.com/golang/go/issues/34536#issuecomment-572188389 suggests we'll need to also backport the fix to 1.18, since the problem also exists in that version.

> Do we have a standard process for backporting one-off fixes to vendored packages, rather than wholesale updates? We have a standard process that applies to golang.org/x dependencies. It uses...

This issue is currently labeled as early-in-cycle for Go 1.15. That [time is now](https://groups.google.com/d/msg/golang-dev/y0yM_Xi665Q/mk35pLnjCAAJ), so friendly ping.