Damien Mathieu
Damien Mathieu
This changes a public API. So it needs a changelog entry. I've opened a PR adding a metadata.yaml to the package. https://github.com/open-telemetry/opentelemetry-collector/pull/14252
This is waiting for a review/approval by an approver.
> Side note: I think it would be nice to have the process of bumping semconv (starting from generating new semconv) to be documented in CONTRIBUTING.md. Yes. This seems like...
@open-telemetry/go-approvers this would welcome a second approval.
cc @akats7 as code owner.
This approach looks good to me. Adding tests would be awesome (there are no tests for the rest of the config unfortunately).
I think this would fall into the same case as [support for OAuth authentication](https://github.com/open-telemetry/opentelemetry-go/issues/4536). TLDR: You can already achieve this with a custom gRPC conn, or HTTP client. We won't...
Wouldn't that skip all of revive? Here's we're skipping a single issue.
Done directly in https://github.com/open-telemetry/opentelemetry-go/pull/6841
This would be an API change that would IMHO need to be described in the specification first.