Damien Mathieu

Results 562 comments of Damien Mathieu

Per the discussion in https://github.com/open-telemetry/opentelemetry-collector/pull/12059, this will be fixed once the collector switched to the config package for setting up telemetry.

Please avoid force-pushing PRs. That breaks the GitHub review UI.

If failures were expected (which doesn't seem to be the case), should we run on both 22.04 and 24.04 (and possibly even 20.04 until it's EOL next april)? Folks will...

I know this is a quite large PR, but there's a lot of repetition in there (which also can't really be reduced). I can split this into multiple PRs, but...

I agree that something more dynamic like a processor would be a better fit here. Depending on your configuration or setup, you may want to send more or less data....

I mean that you may want to send some errors as-is, and hide the details for others. The filter processor is definitely not the right place for this. But a...

cc @akats7 @scorpionknifes as code owners of HTTP implementations

I've added a sample implementation of an `http.Handler` to show what it would look like for implementations. I'm happy to provide a full implementation of `otelhttpconv` as well, to make...

> It would be nice to have a working prototype as a separate draft PR. I intend to do that. But I'd rather have the spec stabilize first, to avoid...