Damien Mathieu

All those attributes are set by the otelhttptrace package. The missing ones: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/ad58c3a23580c5e441928602b45a447e692af481/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go#L27-L37 The header ones: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/ad58c3a23580c5e441928602b45a447e692af481/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go#L342 We should definitely fix the `http.request.header` ones, and make them match the semconv...

Those attributes are for spans, not metrics. Span attributes are meant to be able to have high cardinality.

We can't review this unless you sign the CLA.

For whoever would like to take this on, what's needed is to deprecate the [samplers/probability/consistent](https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/samplers/probability/consistent) package, then wait for one release before removing it from the codebase.

Those metrics are not stable yet. So we need to hide them behind a feature flag.

I'm open to a contribution, but they should be hidden behind a flag. I'd recommend looking at the x packages in the core sdk.

Yes. Unstable metrics may change their name, or attributes. But those end up as breaking changes for us, and the migrations are always tricky.

Urgh sorry, I missed the lack of second approval.

This also changes some unrelated formatting of the file, making the diff harder to read. Could you remove those unrelated formats ?

Sorry for the stale PR. With #6436, I think this becomes unneeded, as all upgrades of the packages will be skipped.