Damien Mathieu
Damien Mathieu
These should first be defined in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/runtime/go-metrics.md
The codecov check is not a blocker. However, it would be nice to have a test case testing your condition and ensuring the grpc credentials value is indeed set.
Couldn't you do the same with [resources](https://pkg.go.dev/go.opentelemetry.io/otel/sdk/resource), and possibly views?
Ignoring that error in otelhttptrace makes sense to me. Do you want to open a PR?
I'd rather assign one of the tasks only, since each is supposed to be a single PR. Which one do you want?
Yes, thank you.
This will need a changelog entry. Also, while this change looks good, I think I recall a discrepency in the specification. I can't find that anymore though.
Since this is an unstable package, we only need to deprecate for one version before we clean up and remove the deprecated code. Communicating through the changelog should be enough.
If we remove the `Post`, `Get` etc, we shouldn't even need to have a public default client anymore.
Let's keep it open until the next release, when we can remove the method entirely.