Damien Mathieu

Results 562 comments of Damien Mathieu

Duplicating code like isn't really maintainable long-term. We should be able to have the metrics recorded, with no code duplication. Possibly, by exporting the metric into its own method. Also,...

This should close https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6940

@alimikegami the CI has been failing since your last commit. Could you fix it?

This error would hint on the semconv migration. Is your commit based on a rather old commit in this repo? The proper metric is the one this CI sees (see...

The latest changes appear to break the tests.

Yes. We can remove in main as soon as a minor release happens.

It seems you have pinged folks at random. You're lucky, I'm a Go SDK maintainer, but please don't do that, as the other two pinged folks are not contributors to...

Side note: the other AWS detectors don't use `github.com/aws/aws-sdk-go`. So they don't need to upgrade.

I don't think it is. So this looks like an issue for the opentelemetry-go repository.