Damien Mathieu
Damien Mathieu
> PS: Also fixed unit tests, where there were assertions inside handlers, which are executed in separate goroutines Could you split that into another PR, to make things easier to...
PRs need two approvals.
Ping @open-telemetry/go-approvers for review. Note that this instrumentation has no owner, and is therefore in the process of being deprecated/removed unless someone steps up to own it (which also explains...
This is a nice idea. I would take a different approach though. In here, the go version is a constant within the test, which means an additional thing to change...
EXPECTED_GO_VERSION seems like a good idea. Could you add tests to the Go file as well?
[Bug]: Unable to reuse http.Request with body when client is instrumented with otelhttp.NewTransport
Thank you for the catch! I believe your first proposal, to use `GetBody` so we use a copy of the body makes sense. We shouldn't ask folks to do things...
Note that this code is auto-generated, as is the doc. The source of reference is here: https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/profiles/v1development/profiles.proto The collector does not generate any profiling data. It gets it from the...
Note that all of profiling is currently in flux, as it's under heavy development. There can, has been and will be breaking changes in the proto definitions.
This API concern had breaking changes but could be considered for a v2. https://github.com/open-feature/go-sdk/issues/259
There are actually two problems here: As you mention, apmotel needs to call `TraceContext()` to properly propagate the span information, which marks the span as having been propagated and prevents...