Dylan T.
Dylan T.
Overview of changes since last reviews: - Overload registration is now substantially changed. - Each command now has only one root overload, which may be either an `ExecutorOverload` (which accepts...
Remaining items of interest: - [ ] Targeting parameters. These are a headache because of their interactions with permissions. - All PM commands currently declare different permissions for targeting `self`...
Would prefer to bind a mapping for it. But also ideally I'd like to implement it in such a way that cases can't suddenly become invalid later on. There's also...
> Why not just create two overloads, where one has the optional literal and the other doesn't? That's what I did, but it's double the number of usages For the...
To be clear, the holdup isn't a lack of solutions, but that decisions haven't been made in affected areas Coordinate params were already implemented, those were quite trivial. I didn't...
Not currently
I think this would be better filled by using [`ReflectionFunction::isAnonymous`](https://www.php.net/manual/en/reflectionfunction.isanonymous.php) in 8.2 and up
Not if we gate it with a `PHP_VERSION_ID` check. This change makes me uneasy. This check was sketchy enough to begin with.
I don't like this, but it's less work than trying to get PHPStan to not complain about any version-conditional logic I tried to implement...
Sorry for all the WTFs btw. Since I'm not familiar with pale moss carpets I was tripping out wondering if you'd vibecoded the class for it 😂