Dylan T. comments

Results 863 comments of


                                            Dylan T.

Implement deserializer cache for readonly tag types and TAG_Compound keys

It eventually occurred to me that the solution to this problem was to just ... not have NBT objects floating around at runtime.

Implement deserializer cache for readonly tag types and TAG_Compound keys

A Tag object cache might be useful for improving performance of chunk reads in PM5, where blockstate NBT data has known possible values. These object allocations currently cost a lot...

Vector3 is now immutable

This requires a PHP 8.2 minimum

Vector3 is now immutable

Supporting 8.2 != minimum 8.2

Vector3 is now immutable

Not before PM6.

Make Vector[23] immutable

This can be solved by moving `Vector3` setters into a `MutableVector3` class and making `Vector3`'s fields protected. However, this has some problems with relation to PM since there's a vast...

Make Vector[23] immutable

My preferred direction for this is to just make Vector3 entirely immutable. In addition, my previous recommendation for `MutableVector3` would have been a bad idea, because it would have also...

Make Vector[23] immutable

Might be a good idea to wait until after 8.1 minimum is imposed for this. 8.1 has `readonly` for properties, which would allow us to continue to allow direct read...

Bump code/mapping from `1e28fa2` to `b6efa95`

@dependabot recreate

Implement pocketmine\world\format\SubChunk natively

I think this is now functionally OK, but it needs to be thoroughly covered by tests before merge. The following things should be tested: - [ ] All public methods...