Jan Kisel comments

Results 8 comments of


                                            Jan Kisel

added test for dynamicconfig/configstore/config_store_client.go

Looks like this tests were added as part of #5983 Closing the PR

Error in generating binary, flag provided but not defined: -i in go build cmd

Thanks for reporting this! It is fixed now.

Add example dockerfile for connecting to remote sql databases.

Hi! I think docker-compose layout assume everything's local, and already configured. How do you see the usage of the proposed configuration?

Cadence Callbacks

@demirkayaender could you explain this more?

Return more information for describeCluster API/command

@longquanzheng pt. 3 is actually just addressed by #6661 Let's address 1,2

Return more information for describeCluster API/command

@samkitshah1262 the idea is following: imagine during rollout you need to check if some cluster' DB schema version is already upgraded from x.y to x.z? Similar for the static configuration...

WIP: increase ratelimit-burst-size for global use

I think the commit-message isn't aligned with the change. I would expect more like tweaking constants for `ratelimit-burst-size`. Is it?

refactor: omit unnecessary reassignment

Let's update the linter, I guess it is outdated since the issue fixed in 1.5+ year ago. Sorry, we can't ignore CI errors and land.